Skip to content

Fix REPL for Java defined types #13701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

BarkingBad
Copy link
Contributor

@BarkingBad BarkingBad commented Oct 6, 2021

Fixes #12346

@BarkingBad BarkingBad requested a review from odersky October 6, 2021 10:24
@BarkingBad BarkingBad linked an issue Oct 6, 2021 that may be closed by this pull request
odersky added a commit to dotty-staging/dotty that referenced this pull request Oct 6, 2021
@odersky odersky mentioned this pull request Oct 6, 2021
@@ -709,6 +709,7 @@ object Checking {

def checkValue(tree: Tree)(using Context): Unit =
val sym = tree.tpe.termSymbol
sym.ensureCompleted()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed.

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge with #13704.

@BarkingBad BarkingBad closed this Oct 7, 2021
odersky added a commit that referenced this pull request Oct 7, 2021
olsdavis pushed a commit to olsdavis/dotty that referenced this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REPL crashes when Java class name given as input
2 participants