Add retry logic to inkuire fetch #13482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griggt
approved these changes
Sep 8, 2021
project/Build.scala
Outdated
| downloadProcess.destroy() | ||
| throw new MessageOnlyException(s"Failed to fetch inkuire.js from $inkuireLink: Download timeout") | ||
|
|
||
| def tryFetch(retries: Int, timeout: Int): Unit = { |
There was a problem hiding this comment.
Suggested change
| def tryFetch(retries: Int, timeout: Int): Unit = { | |
| def tryFetch(retries: Int, timeout: Duration): Unit = { |
Consider using Duration here and updating the code accordingly.
project/Build.scala
Outdated
| tryFetch(retries - 1, timeout) | ||
| } | ||
| else { | ||
| downloadProcess.destroy() |
There was a problem hiding this comment.
Do we want also want this call to downloadProcess.destroy() for the if branch above when we catch TimeoutException?
There was a problem hiding this comment.
yes, we should destroy process in both branches
pikinier20
force-pushed
the
scaladoc/inkuire-retry
branch
from
b88c504 to
1200580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even after increasing timeout limit, inkuire fetch is still flaky. This PR adds retry logic to stabilize the process