Widen type of final vars #1285 #1348
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When defining a final var, the type is not widened and, thus, it's as specific as possible. However, when changing the value of the var, it will give a compilation error because it cannot match the constant types. This fix widens the type whenever it finds a final var.
|
I don't think this is the only thing that needs to be done to fix #1285. In the issue comments we determined that |
| } | ||
| vdef | ||
| } | ||
|
|
||
| /** Add a @volitile to lazy vals when rewriting from Scala2 */ | ||
| private def patchIfLazy(vdef: ValDef)(implicit ctx: Context): Unit = { |
There was a problem hiding this comment.
There's a simpler way to do it. In Namer.scala
def isInline = sym.is(Final, butNot = Method)
We just need to exclude Mutable here. E.g.
def isInline = sym.is(Final, butNot = Method | Mutable)
|
You could change the commit message to |
|
Superseded by #1428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1285.
When defining a final var, the type is not widened and, thus, it's as
specific as possible. However, when changing the value of the var, it
will give a compilation error because the constant types don't match.
This fix widens the type whenever it finds a final var.