Code

Fix init soundness#13472

Code

Merged

olhotak merged 51 commits intoscala:masterscala/scala3:masterfrom

dotty-staging:fix-init-soundnessdotty-staging/dotty:fix-init-soundnessCopy head branch name to clipboard

Oct 14, 2021

Commits

Commits on Oct 7, 2021

• Update tests

  

  EnzeXing

  authored and

  liufengyun

  committed
  857cc74

  Copy full SHA for 857cc74

• Add worklist and refactor definition for ThisRef

  Show description for ef43eb5
  liufengyun

  committed
  ef43eb5

  Copy full SHA for ef43eb5

• Rename Addr to Ref

  liufengyun

  committed
  5d1fe86

  Copy full SHA for 5d1fe86

• Refactor: make state explicit

  liufengyun

  committed
  7279f73

  Copy full SHA for 7279f73

• Add constructor to Warm

  liufengyun

  committed
  20ff7ca

  Copy full SHA for 20ff7ca

• Revert ThisRef to previous version

  liufengyun

  committed
  f5651b5

  Copy full SHA for f5651b5

• Refactor constructor call

  liufengyun

  committed
  6763285

  Copy full SHA for 6763285

• Make cache part of state

  liufengyun

  committed
  ab09fd2

  Copy full SHA for ab09fd2

• Handle cache in work list

  liufengyun

  committed
  98f9f7e

  Copy full SHA for 98f9f7e

• Don't iterate if errors found

  liufengyun

  committed
  fb0c347

  Copy full SHA for fb0c347

• Revert heap changes if cache has changed

  liufengyun

  committed
  69e314e

  Copy full SHA for 69e314e

• Restore cacheResult option for eval

  liufengyun

  committed
  db11295

  Copy full SHA for db11295

• Handle callConstructor

  liufengyun

  committed
  111ac87

  Copy full SHA for 111ac87

• Reset Cache.changed after each iteration

  liufengyun

  committed
  29bdb5d

  Copy full SHA for 29bdb5d

• Tweak log printing of errors

  liufengyun

  committed
  0b1b21f

  Copy full SHA for 0b1b21f

• Fix context for init check

  Show description for c5daf1d
  liufengyun

  committed
  c5daf1d

  Copy full SHA for c5daf1d

• Introduce global cache which holds fixed point value

  liufengyun

  committed
  4a71470

  Copy full SHA for 4a71470

• Update tests

  liufengyun

  committed
  375e0e5

  Copy full SHA for 375e0e5

• Avoid asInstanceOf in logging

  liufengyun

  committed
  6188e8e

  Copy full SHA for 6188e8e

• Refactor cache

  liufengyun

  committed
  5bdd898

  Copy full SHA for 5bdd898

• Cache default value in the input cache

  liufengyun

  committed
  9ea3624

  Copy full SHA for 9ea3624

• Rename global cache to stable cache

  liufengyun

  committed
  d0e71a2

  Copy full SHA for d0e71a2

• Better encapsulate Cache.assume

  liufengyun

  committed
  fe3930d

  Copy full SHA for fe3930d

• Rename in/out to last/current

  liufengyun

  committed
  5bd83ae

  Copy full SHA for 5bd83ae

• Mark arguments as constructor only

  liufengyun

  committed
  2589824

  Copy full SHA for 2589824

• Add note for tempting but unsound optimization

  liufengyun

  committed
  2849052

  Copy full SHA for 2849052

• Commit cache to stable on error

  Show description for 8a4fe78
  liufengyun

  committed
  8a4fe78

  Copy full SHA for 8a4fe78

• Make sure the object of a reference assumption value exists

  liufengyun

  committed
  5b00b1f

  Copy full SHA for 5b00b1f

• Add back arguments to ThisRef

  liufengyun

  committed
  04aa72b

  Copy full SHA for 04aa72b

• Populate parameters of Warm objects by reusing init

  liufengyun

  committed
  ad503fc

  Copy full SHA for ad503fc

• Make sure the class parameters and outers of warm objects are populated

  liufengyun

  committed
  fb3b6ca

  Copy full SHA for fb3b6ca

• Use correct trace

  liufengyun

  committed
  bc98ce8

  Copy full SHA for bc98ce8

• Populate class parameters for warm objects in a heap prepare step

  liufengyun

  committed
  b27d58b

  Copy full SHA for b27d58b

• Try to check warm values immediately

  liufengyun

  committed
  99df102

  Copy full SHA for 99df102

• Fix crash: make sure object fresh before calling init

  Show description for 4163fd3
  liufengyun

  committed
  4163fd3

  Copy full SHA for 4163fd3

• Be more sensitive for values Warm(outer = ThisRef)

  liufengyun

  committed
  683d537

  Copy full SHA for 683d537

• Fix non-determinism in test

  liufengyun

  committed
  ccbb355

  Copy full SHA for ccbb355

• Make isPopulatingParams a flag in Warm

  liufengyun

  committed
  fc76549

  Copy full SHA for fc76549

• Make heap as part of cache

  Show description for 191877a
  liufengyun

  committed
  191877a

  Copy full SHA for 191877a

• Update test

  liufengyun

  committed
  f5540f5

  Copy full SHA for f5540f5

• Add more debugging information

  liufengyun

  committed
  a15a06c

  Copy full SHA for a15a06c

• Lazily populate warm objects

  liufengyun

  committed
  46793f1

  Copy full SHA for 46793f1

• Add comment

  liufengyun

  committed
  8bbe384

  Copy full SHA for 8bbe384

• Fix non-termination

  Show description for dab8181
  liufengyun

  committed
  dab8181

  Copy full SHA for dab8181

• Fix pickling test

  liufengyun

  committed
  1ab5316

  Copy full SHA for 1ab5316

• Remove unused parameters of ThisRef

  liufengyun

  committed
  1e802c9

  Copy full SHA for 1e802c9

• Fix compilation of scodec

  Show description for 8088217
  liufengyun

  committed
  8088217

  Copy full SHA for 8088217

• Apply suggestions from code review

  Show description for 6566756
  

  3 peoplecommitted
  6566756

  Copy full SHA for 6566756

• Address review comments

  liufengyun

  committed
  15a51d7

  Copy full SHA for 15a51d7

• Address review: Add comment to populateParams

  liufengyun

  committed
  7ee58a3

  Copy full SHA for 7ee58a3

• Fix compilation

  liufengyun

  committed
  e905cd5

  Copy full SHA for e905cd5