[WIP] Add methods to abstract over structure of case classes #1346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #1341, I decided to take a crack at improving case classes. These commits add two members to case classes:
def fields: List[String]
def toMap: Map[String, Any]
I think it is important to have a good way of abstracting over the members of case classes, this provides just that. One drawback to having this signature in the
toMap
method is that we loose type information. Ideally something like anHMap
could be used here to retain type information.There's room for improvement in this implementation as well - for instance
def fields
could of course be a@static val fields
in the companion instead.These two functions could in turn be used to improve the
toString
capabilities of case classes as well as various forms of pickling. Let me know your thoughts on this - if it feels like a step in the right direction, I wouldn't mind spending some time on this.