-
Notifications
You must be signed in to change notification settings - Fork 1.1k
patch TASTy version to 28.1-0 for 3.1.0 final #13452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch TASTy version to 28.1-0 for 3.1.0 final #13452
Conversation
Scala 3.0.x was tasty 28.0.x, shouldn't Scala 3.1.x be tasty 28.1.x ? |
the 3.1.0-RC1 release was accidentally set to |
#13386 bumped 28.1-1 to 28.2-1 instead of 28.1-0 (though now we know that should wait for the final release anyways). TBH this is tricky to get right, so let's detail it well in the release procedure. |
I see, but I wouldn't worry too much about people accidentally using 3.1.0-RC1 and accidentally depending on a 3.2.0 library, they're using an RC so it's on them anyway, so I don't think it's a problem to use 28.1 here and 28.2 in for 3.2 |
master branch has already been set to |
Yeah so it'd have to be set to 28.2-1 too, though again not a big deal since it's only about nightlies. |
I'm with Guillaume on this, btw. Easier to pretend the mistaken use of 28.1-0 never happened, and fix both the release-3.1.0 and master branches. Otherwise the numbers will always be skewed and need explaining, which is annoying and very likely unnecessary. |
ok so should we patch this branch immediately to maybe 28.1-2 so that it is still experimental if there is an RC2, and then master goes back to 28.2-1? |
Yes, I'd say so. |
98bb905
to
f017d5e
Compare
The PR is ready, but just to avoid it being accidentally merged too early. |
closing as 89ad511 implements the same fix |
to be merged when
3.1.0
is released