-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Set up versions for development after 3.1.0-RC1 #13439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
project/Build.scala
Outdated
@@ -81,7 +81,7 @@ object Build { | |||
* set to 3.1.3. If it is going to be 3.1.0, it must be set to the latest | |||
* 3.0.x release. | |||
*/ | |||
val previousDottyVersion = "3.0.2" | |||
val previousDottyVersion = "3.1.0-RC1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to wait until we have 3.1.0
to update this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will probably have to keep the MiMaFilters for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then we would need to add lots of exceptions to MiMa, as it wants to check for both forward and backward compatibility between 3.0.2
and what is currently on master. It works like that because 3.1.1
is considered as a patch release and that's why it needs release from the same versioning line to be compared to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember exactly why, but last time I was told that we should do it like this. As it is written in the documentation above. @smarter I believe you where the one that told me that. Is that true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok. So I think the change do to is keep this to 3.0.2 but change baseVersion to 3.1.0-RC2 (or something 3.1.0*). That way the logic in compatMode
won't start enforcing bidirectional checking.
We can also move |
And |
@Kordyjan this branch should not have been created in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
This PR sets the
referenceVersion
andpreviousDottyVersion
to3.1.0-RC1
as the first release from the 3.1 versioning line.It also sets
baseVersion
to3.1.1-RC1
as it should be the version to which all new PRs should be merged to by default. I suggest that changes that we want to release in3.1.0-RC2
should be merged/backported torelease-3.1.0
branch (see #13438).