Add ClassDef.baseTypes to reflection API #13398
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pikinier20
force-pushed
the
add-supertypes
branch
2 times, most recently
from
a474421 to
5409db1
Compare
smarter
reviewed
Aug 26, 2021
pikinier20
changed the title
pikinier20
force-pushed
the
add-supertypes
branch
from
f836d7a to
debb95a
Compare
|
Part of #13371 |
nicolasstucki
force-pushed
the
add-supertypes
branch
from
debb95a to
c16be38
Compare
nicolasstucki
suggested changes
Jan 13, 2022
| @@ -79,6 +79,7 @@ trait ClassLikeSupport: | |||
| else Seq(link -> superLink) ++ getSupertypesGraph(superLink, nextTo) | |||
| } | |||
|
|
|||
| // TODO use classDef.baseTypes | |||
There was a problem hiding this comment.
@pikinier20 SInce you created this PR the code below changed. Is this method still relevant or is Symbol.baseCalsses enough?
| @@ -0,0 +1,3 @@ | |||
| List(scala.Int, scala.AnyVal, scala.Matchable, scala.Any) | |||
| List(java.lang.Object, scala.Matchable, scala.Any) | |||
| List(scala.Some[Some.this.A], scala.Option[Some.this.A], java.io.Serializable, scala.Product, scala.Equals, scala.collection.IterableOnce[Some.this.A], java.lang.Object, scala.Matchable, scala.Any) | |||
There was a problem hiding this comment.
Adding this test I noticed that baseTypes is losing the type parameters. It might need to be implemented on TypeRepr directly.
|
The problem was solved by #14892 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.