Skip to content

Add Position.exists to reflection API #13397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add Position.exists to reflection API #13397

wants to merge 3 commits into from

Conversation

pikinier20
Copy link
Contributor

No description provided.

@nicolasstucki
Copy link
Contributor

I believe all positions should exist at this point. We should trace back where this is used in the docs and figure out why we do not have a position.

@pikinier20
Copy link
Contributor Author

pikinier20 commented Aug 27, 2021 •
edited
Loading

There's an issue about non-existing positions: #13352

Also, I've tried to generate documentation for standard library without checking if Position exists and it fails.

@nicolasstucki
Copy link
Contributor

So exists in the docs is there to work around a bug. If that is the case we should not add it to the public API.

@pikinier20
Copy link
Contributor Author

Ok, so we will just leave the hack until the bug is fixed.

@pikinier20 pikinier20 closed this Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki Awaiting requested review from nicolasstucki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pikinier20 @nicolasstucki