Restore unreachable warnings by converting literals #13289
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix implemented to deal with primitive types auto-converting was suppressing a series of legitimate unreachable warnings. So we removed that fixed and tried to mirror the auto-conversion of the type, such that the space intersection calculation ends up with the correct results. In doing so we triggered reachability warnings being emitted by sealed trait companion object (or enum) `ordinal` synthetic methods, in some weird test cases. So we added an `@unchecked` annotation to suppress those. Co-authored-by: Seth Tisue <[email protected]>
|
Wrong branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix implemented to deal with primitive types auto-converting was
suppressing a series of legitimate unreachable warnings. So we removed
that fixed and tried to mirror the auto-conversion of the type, such
that the space intersection calculation ends up with the correct
results.
In doing so we triggered reachability warnings being emitted by
sealed trait companion object (or enum)
ordinalsynthetic methods, insome weird test cases. So we added an
@uncheckedannotation tosuppress those.
Fixes #12805