-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Don't export members that will be synthesized in case classes #13234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5dd0ba5
Don't export members that will be synthesized in case classes
odersky b7b4746
Integrate tests in method where they are needed
odersky ec82153
Address review comments
odersky c91a99a
Fix typo
odersky 1526271
Fix tasty extractors expect file
odersky c0d0d5d
Fix checkfile for tasty-extractors-2
nicolasstucki 48aac8e
Make caseClassSynthesized idempotent
nicolasstucki db38c76
Fix checkfile for tasty-extractors-2
nicolasstucki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
RegisteredUser(Id,User(Name)) | ||
false | ||
false | ||
false | ||
false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
case class User(name: String) | ||
|
||
case class RegisteredUser(id: String, data: User) { | ||
export data.* | ||
} | ||
|
||
@main def Test() = | ||
println(RegisteredUser("Id", User("Name"))) // RegisteredUser(Name) | ||
println(RegisteredUser("Id", User("Name")).canEqual(User("Name"))) // True | ||
// The rest works as expected | ||
println(RegisteredUser("Id", User("Name")) == User("Name")) // False | ||
println(RegisteredUser("Id", User("Name")).hashCode == User("Name").hashCode) // False | ||
println(RegisteredUser("Id", User("Name")).productArity == User("Name").productArity) // False |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.