test added to BashScriptsTests to verify script.path property #13132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
BarkingBad
reviewed
Jul 27, 2021
| @@ -56,8 +56,7 @@ class ClasspathTests: | |||
| printf("bash is [%s]\n", bashExe) | |||
|
|
|||
| if packBinScalaExists then | |||
| val echoTest = "" // "SCALAC_ECHO_TEST=1" | |||
| val bashCmdline = s"SCALA_OPTS= $echoTest ${scalaCopy.norm} -classpath '$wildcardEntry' $relpath" | |||
| val bashCmdline = s"SCALA_OPTS= ${scalaCopy.norm} -classpath '$wildcardEntry' $relpath" | |||
There was a problem hiding this comment.
Why scala script path is part of SCALA_OPTS?
There was a problem hiding this comment.
The purpose of prefixing the bash command line with SCALA_OPTS= is to unset SCALA_OPTS, to insure that it doesn't influence the command line args seen by dist/bin/scala. (there's a space following the equal sign, effectively unsetting SCALA_OPTS)
There was a problem hiding this comment.
Oh yeah, I was curious about the blank space too, but now it makes sense
BarkingBad
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding 2 new tests to verify behavior of scripts called via
bash -ccommand line.It's failing
Dotty / testdue to script file not having execute permission, not sure how best to work around this problem:I modified the 2 new script tests in
BashScriptTeststo only fail if the script runs successfully AND the expected output is as expected.