Skip to content

Merge the sbt compiler bridge as a subproject of dotty #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2016

Conversation

smarter
Copy link
Member

@smarter smarter commented Jun 4, 2016

Note that if we want to run the bridge tests on every PR we should add the following to a Jenkins job:

sbt bridge/test
sbt bridge/scripted

The scripted tests take a fair amount of time (27 minutes here) so we may not want to do that right now, this will get better once we base ourselves on sbt 1.0.

@smarter
Copy link
Member Author

smarter commented Jun 4, 2016

Review by @felixmulder

@felixmulder
Copy link
Contributor

LGTM (once those two comments have been answered)

@felixmulder
Copy link
Contributor

Also, great job! I think we can all agree that you're the MVP of the week! 🎉

@smarter smarter force-pushed the add/dotty-bridge branch from 47b6c5c to 7f026aa Compare June 5, 2016 04:48
@DarkDimius
Copy link
Contributor

I'd prefer to have commits in this PR squashed for several reasons:

  • they do not show up on github;
  • they make my local tooling(SourceTree) go into infinite cycle;
  • the last commit in any case screws the blame history(at least in my IDE) so I don't see much value in maintaining it given that it breaks tooling(both on github and locally).

Otherwise LGTM.

@smarter
Copy link
Member Author

smarter commented Jun 7, 2016

the last commit in any case screws the blame history

git blame bridge/src/main/scala/xsbt/CompilerInterface.scala seems to display the correct thing.

Anyway, seems like you're trying to use a bunch of broken tools, feel free to change this PR to make them work with your tools, but maybe you should change tools ;)

@smarter
Copy link
Member Author

smarter commented Jun 7, 2016

If you do squash the commits, the commit message should at least include a link to https://github.com/smarter/dotty-bridge so that people can find the real history.

Note that the dotty-bridge tests will not be run automatically by `test`
which is short for `dotty/test`, to run the dotty-bridge tests, do in sbt:
> dotty-bridge/test
> dotty-bridge/scripted

Original history: https://github.com/smarter/dotty-bridge/commits/master
@felixmulder felixmulder merged commit 002ed8e into scala:master Jun 7, 2016
@allanrenucci allanrenucci deleted the add/dotty-bridge branch December 14, 2017 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants