-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Search for name in range of lines and add flexible sourcelinks #12819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1244,7 +1244,12 @@ object Build { | |
// TODO add versions etc. | ||
def srcManaged(v: String, s: String) = s"out/bootstrap/stdlib-bootstrapped/scala-$v/src_managed/main/$s-library-src" | ||
def scalaSrcLink(v: String, s: String) = s"-source-links:$s=github://scala/scala/v$v#src/library" | ||
def dottySrcLink(v: String, s: String) = s"-source-links:$s=github://lampepfl/dotty/$v#library/src" | ||
def dottySrcLink(v: String, s: String) = | ||
sys.env.get("GITHUB_SHA") match { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The problem is that we want to link to the source code that has been actually used for this PR, not the 3.0.0 sources. Before we tried to link to e.g. experimental.scala that that not exists in 3.0.0 |
||
case Some(sha) => | ||
s"-source-links:$s=github://${sys.env("GITHUB_REPOSITORY")}/$sha#library/src" | ||
case None => s"-source-links:$s=github://lampepfl/dotty/$v#library/src" | ||
} | ||
|
||
val revision = Seq("-revision", ref, "-project-version", projectVersion) | ||
val cmd = Seq( | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
--- | ||
title: Adoc | ||
--- | ||
# Header in Adoc | ||
|
||
[A link to](dir/html.md) | ||
[A link to](dir/name...with..dots..md) | ||
[A link to](dir/name.with.md.and.html.md) | ||
[A link to](dir/nested.md) | ||
[A link to](dir/nested.svg) | ||
|
||
|
||
|
||
And a text! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
title: html named file | ||
--- | ||
|
||
And a text! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
title: A directory | ||
--- | ||
# {{ page.title }} | ||
|
||
And a text! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
title: Strange name multipke dots in nane | ||
--- | ||
|
||
And a text! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
title: name.with.md.and.html | ||
--- | ||
|
||
And a text! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
title: Nested in a directory | ||
--- | ||
# {{ page.title }} | ||
|
||
And a text! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# {{ page.title }} in header | ||
|
||
And a text! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was
site.baseurl
empty string?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we do not expose such setting