Use == for instance tests against string constants
#12799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used `eq` before, as for other objetc singletons. But this means we are subject to the vagaries of string hashing. Fixes scala#12796
| @@ -963,8 +963,10 @@ object tpd extends Trees.Instance[Type] with TypedTreeInfo { | |||
|
|
|||
| /** `tree.isInstanceOf[tp]`, with special treatment of singleton types */ | |||
| def isInstance(tp: Type)(using Context): Tree = tp.dealias match { | |||
| case ConstantType(c) if c.tag == StringTag => | |||
There was a problem hiding this comment.
Shouldn't we do it for other constants?
There was a problem hiding this comment.
The only constant types supporting the alternative comparison with eq are classes and strings. Class literals are hash consed, so == and eq are the same. So I believe String is the only type in need of a fix.
There was a problem hiding this comment.
To add, I didn't find this issue with integer constants.
There was a problem hiding this comment.
Null might also take advantage of this unless some other optimization is already handling it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used
eqbefore, as for other objetc singletons. But this meanswe are subject to the vagaries of string hashing.
Fixes #12796
Fixes #6996