Use the correct scalaBinaryVersion for releases #12578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the non-bootstrapped 3.0.1-RC1 would have had version `3.0.1-nonbootstrapped` for which sbt would compute the binary version `3.0.1-nonbootstrapped` since we publish a compiler compiled with that version, this is the binary version that would have ended up on Maven. Fixed by instead making sure the non-bootstrapped release version is `3.0.1-bin-nonbootstrapped` which sbt will interpret correctly.
smarter
changed the title
smarter
force-pushed
the
fix-binaryVersion-2
branch
from
b253559 to
dc79439
Compare
adpi2
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the non-bootstrapped 3.0.1-RC1 would have had version
3.0.1-nonbootstrappedfor which sbt would compute the binary version3.0.1-nonbootstrappedsince we publish a compiler compiled with thatversion, this is the binary version that would have ended up on Maven.
Fixed by instead making sure the non-bootstrapped release version is
3.0.1-bin-nonbootstrappedwhich sbt will interpret correctly.