Tighten Ycheck of type ascriptions #12513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously did not check that Typed nodes are type-correct, i.e. that the type of the expression conforms to the given type. Now we do. This uncovered problems in three different places: - for internal gadt ascriptions, where a cast should be used instead of a type ascription. - for avoidance, where two tests fail - for PCPCheckAndHeal, where at least one test fails For now, the logic in avoidance is changed so that we use a cast if an ascription is incorrect. But this should be fixed so that the cast is never needed, if possible. After the inlining phase, we fall back to the old logic for typedTyped that does not check conformance. This is because of PCPCheckAndHeal. This problem should also be followed up. We also had to disable one FromTasty test to pass the stricter requirements
abgruszecki
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously did not check that Typed nodes are type-correct,
i.e. that the type of the expression conforms to the given type.
Now we do. This uncovered problems in three different places:
a type ascription.
For now, the logic in avoidance is changed so that we use a cast if an ascription
is incorrect. But this should be fixed so that the cast is never needed, if possible.
After the inlining phase, we fall back to the old logic for typedTyped that
does not check conformance. This is because of PCPCheckAndHeal. This problem should also be
followed up.