Replace useless @SerialVersionUID error by a warning #12505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka has this annotations on some traits and cannot remove it without breaking binary-compatibility on 2.12, they worked around this error by using a compiler plugin, but we can just downgrade the error to warning so they don't have to keep doing something that horrifying.
nicolasstucki
approved these changes
May 18, 2021
|
Thanks for removing my excuse for playing around with Scala 3 compiler plugins :-P |
andreaTP
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
akka has this annotations on some traits and cannot remove it without
breaking binary-compatibility on 2.12, they worked around this error
by using a compiler plugin, but we can just downgrade the error to
warning so they don't have to keep doing something that horrifying.
/cc @andreaTP