Silence a debug println #12257
Merged
Silence a debug println #12257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Apr 28, 2021
| @@ -791,7 +791,7 @@ object Denotations { | |||
| val currentPeriod = ctx.period | |||
| val valid = myValidFor | |||
|
|
|||
| def signalError() = println(s"error while transforming $this") | |||
| def signalError() = () //println(s"error while transforming $this") | |||
There was a problem hiding this comment.
Since that method is only used in one place I would just replace its call by the commented out println
There was a problem hiding this comment.
Why not use one of the Printers?
There was a problem hiding this comment.
There isn't a good Printer to use here. Nearby code just uses println.
Currently, when running testCompilation i1286, the following always gets printed: error while transforming method splitAt error while transforming method tuple2ToZippedOps It seems that the associated error gets caught and handled, so we shouldn't print this message.
abgruszecki
force-pushed
the
silence-transforming-error
branch
from
9b3bbeb to
3c7a682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when running testCompilation i1286, the following always gets printed:
error while transforming method splitAt
error while transforming method tuple2ToZippedOps
It seems that the associated error gets caught and handled, so we shouldn't print this message.