Fix #12050: catch StackOverflow in tryNormalize #12250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect that the refactoring in scala#12053 turned scala#12050's infinite loop into a stack overflow, which is easy to catch. Although this doesn't completely fix the issue (we can't guarantee that no stack-consuming loops exist), I think all the looping examples we have so far error out gracefully.
odersky
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect that the refactoring in #12053 turned #12050's infinite loop into a stack overflow, which is easy to catch.
Although this doesn't completely fix the issue (we can't guarantee that no stack-consuming loops exist), I think all the looping examples we have so far error out gracefully.