-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Cache quote unpickling #12242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nicolasstucki
merged 2 commits into
scala:master
from
dotty-staging:add-cache-to-quote-unpickling
Apr 29, 2021
Merged
Cache quote unpickling #12242
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package dotty.tools.dotc.quoted | ||
|
||
import dotty.tools.dotc.core.Contexts._ | ||
import dotty.tools.dotc.util.Property | ||
import dotty.tools.dotc.reporting.trace | ||
import dotty.tools.dotc.ast.tpd | ||
|
||
import scala.collection.mutable | ||
|
||
object QuotesCache { | ||
import tpd._ | ||
|
||
/** A key to be used in a context property that caches the unpickled trees */ | ||
private val QuotesCacheKey = new Property.Key[collection.mutable.Map[String | List[String], Tree]] | ||
|
||
|
||
/** Get the cached tree of the quote */ | ||
def getTree(pickled: String | List[String])(using Context): Option[Tree] = | ||
ctx.property(QuotesCacheKey).get.get(pickled) | ||
|
||
/** Update the cached tree of the quote */ | ||
def update(pickled: String | List[String], tree: Tree)(using Context): Unit = | ||
ctx.property(QuotesCacheKey).get.update(pickled, tree) | ||
|
||
/** Context with a cache for quote trees and tasty bytes */ | ||
def init(ctx: FreshContext): ctx.type = | ||
ctx.setProperty(QuotesCacheKey, collection.mutable.Map.empty) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case we have optimizations that make the
TreeTypeMap
and identity function, do we have a test to guard against such optimizations?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already do that optimization outside
TreeTypeMap
, for example inchangeOwner
.We do have tests that would fail if this stops cloning the symbols.