Fix isMatch #12206
Merged
Fix isMatch #12206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid steps can yield match types that should be normalized to keep things clean. This means avoidance does the same steps as simplification in this respect. Fixes scala#12194
An applied type that is an alias of an applied match type is an applied match type itself. Previously that was not the case, which led to typed that could logically be reduced but were not.
OlivierBlanvillain
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An applied type that is an alias of an applied match type is an applied match type itself.
Previously that was not the case, which led to typed that could logically be reduced but were
not.
Fixes #12194
There, the case was that we had a Tuple.Union type that was an alias of a Tuple.Fold type instance, which was an alias
of a match type. The Tuple.Union did did not get reduced since it was not regarded as a match type alias itself.