Cancel quotes while inlining #12193
Merged
Cancel quotes while inlining #12193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Apr 23, 2021
| tree match | ||
| case Quoted(Spliced(inner)) => inner | ||
| case _ => tree | ||
| val res = cancelQuotes(constToLiteral(betaReduce(super.typedApply(tree, pt)))) match { |
There was a problem hiding this comment.
The fix failed the following code:
inline def test[T](inline t: T): T = ${ identity('{ identity(${ identity('{ identity(${ identity('t) }) }) }) }) }There was a problem hiding this comment.
That is a different problem. I will open an issue for it. See #12225.
There was a problem hiding this comment.
What about this one:
inline def test[T](inline t: T): T = ${ '{ ${ '{ ${ 't } } } } }There was a problem hiding this comment.
That one works. Added it as a regression test.
nicolasstucki
force-pushed
the
fix-#12173
branch
from
9d210f4 to
cbab359
Compare
The last top level splice is handled by the Splicer Fixes scala#12173
nicolasstucki
force-pushed
the
fix-#12173
branch
from
cbab359 to
2a97c3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last top level splice is handled by the Splicer
Fixes #12173