Fix trait setter validity #12144
Fix trait setter validity #12144
Conversation
| @@ -146,6 +147,7 @@ class Mixin extends MiniPhase with SymTransformer { thisPhase => | |||
| // !decl.isClass avoids forcing nested traits, preventing cycles | |||
| if !decl.isClass && needsTraitSetter(decl) then | |||
| val setter = makeTraitSetter(decl.asTerm) | |||
| setter.validFor = Period(ctx.runId, thisPhase.next.id, decl.validFor.lastPhaseId) | |||
There was a problem hiding this comment.
I think we can use thisPhase.validFor here, this is what we had to do in https://github.com/lampepfl/dotty/blob/0ca0b9ea27620089291eae7716590b749298533d/compiler/src/dotty/tools/dotc/transform/ExtensionMethods.scala#L66-L74
|
Now I get: Unable to get Dotty latest nightly build version. Make sure you are connected to internet in CommunityBuildC, when trying to compile shapeless. Any ideas what this could be? |
|
Another PR of mine fails for the same reason, so it looks like a CI problem. |
|
not sure, but I see shapeless has been updated upstream to remove the call to dottyLatestNightly, @milessabin could you open a PR to update shapeless in our community build? |
|
Publishing 3.0.0-RC3 today made I believe this will fix itself after the next successful nightly build, but |
Trait setters had a validity interval that started before they were created. This caused stale symbol errors in macro compilations.
Trait setters had a validity interval that started before they were created.
This caused stale symbol errors in macro compilations.
Fixes #12140