Make annotation reading lazier in Scala2Unpickler #12117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
changed the title
Eta expansion needs type parameters which can provoke a cycle. Fixes scala#12109.
Fixes scala#12109 without causing problems elsewhere.
smarter
approved these changes
Apr 18, 2021
| @@ -0,0 +1 @@ | |||
| sbt.version=1.3.12 | |||
There was a problem hiding this comment.
That build.properties file isn't needed for a scripted test.
There was a problem hiding this comment.
I copied everything from the scala-compat test that you added recently.
There was a problem hiding this comment.
Hmm, I don't see that file in https://github.com/lampepfl/dotty/pull/12120/files, it might have been auto-generated by sbt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking whether we need eta expansion needs type parameters which can provoke a cycle.
Fixes #12109.