Improve invariant checks for erased terms #12095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
improve-erased-terms-erasure
branch
from
4c59649 to
865c662
Compare
|
Seems that it caught a bug in |
|
That failure was just another instance of #11996 |
nicolasstucki
force-pushed
the
improve-erased-terms-erasure
branch
from
865c662 to
d3f08a7
Compare
|
|
nicolasstucki
force-pushed
the
improve-erased-terms-erasure
branch
3 times, most recently
from
d7922bd to
5cad755
Compare
Instead of erasing an erased term to `???` we erase it to `erasedValue[T]`. This has 2 advantages, first, the term does not lose its type, and second, the term is still marked as erased. The second implies that if there is a bug in the compiler or a macro where the term might end outside an erased context, the code will not compiler. Currently, the code compiles and then throws when calling the spurious `???`. See scala#11996.
nicolasstucki
force-pushed
the
improve-erased-terms-erasure
branch
from
5cad755 to
e152abe
Compare
odersky
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of erasing an erased term to
???we erase it toerasedValue[T].This has 2 advantages, first, the term does not lose its type, and second, the
term is still marked as erased. The second implies that if there is a bug in
the compiler or a macro where the term might end outside an erased context, the
code will not compiler. Currently, the code compiles and then throws when
calling the spurious
???. See #11996.