Improve constant folding logic #12080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#12072
branch
3 times, most recently
from
b28e5b2 to
ca46f64
Compare
* Better handling of inlined expression * Constant fold `String.!=` * Handle `null` in `==` and `!=` Fixes scala#12072
nicolasstucki
force-pushed
the
fix-#12072
branch
from
ca46f64 to
6a25712
Compare
odersky
requested changes
Apr 14, 2021
| @@ -59,6 +59,16 @@ object ConstFold: | |||
| tree.withFoldedType(Constant(targ.tpe)) | |||
| case _ => tree | |||
|
|
|||
| private def treeConstant(tree: Tree)(using Context): Option[Constant] = | |||
There was a problem hiding this comment.
I think it would be more elegant if ConstantTree was an extractor.
There was a problem hiding this comment.
Moved to ConstantTree extractor
|
I'm not sure if it's relevant here, but is it possible to have constant folding in string interpolation (meaning that if all arguments are constant then the interpolation result will be constant as well)? |
|
Constant folding on string interpolators is a separate and more complex issue (see #10315). |
odersky
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.!=nullin==and!=Fixes #12072