Fix Java lookups #12070
Merged
Fix Java lookups #12070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abgruszecki
reviewed
Apr 13, 2021
| @@ -108,7 +108,7 @@ trait MemberLookup { | |||
| given dotc.core.Contexts.Context = quotes.asInstanceOf[scala.quoted.runtime.impl.QuotesImpl].ctx | |||
| val sym = rsym.asInstanceOf[dotc.core.Symbols.Symbol] | |||
| // note: Predef has .info = NoType for some reason | |||
| sym.isCompleted && sym.info.exists | |||
| (sym.isCompleted && sym.info.exists) || sym.infoOrCompleter.isInstanceOf[dotty.tools.dotc.core.ClassfileLoader] | |||
There was a problem hiding this comment.
Nice! Can you test if the reverse logic works? I.e. instead of checking if sym.isCompleted, check if .infoOrCompleter is instance of DottyUnpickler. (I think that's the correct class.) It's better to blacklist loaders we know to misbehave, I think.
There was a problem hiding this comment.
Good idea with blacklisting, will check that one tomorrow
BarkingBad
force-pushed
the
scaladoc/java-lookups
branch
from
c7ae254 to
a2e2a3d
Compare
|
Could you @abgruszecki take a look again, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.