sbt-dotty: the binary version is 3 for Scala >= 3.0.0 #11952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
approved these changes
Mar 31, 2021
|
sbt is broken because of sbt/sbt#6422 (which we could work around), mill is broken because of com-lihaoyi/mill#1139 |
adpi2
force-pushed
the
fix-scalaBinaryVersion
branch
5 times, most recently
from
ea38615 to
8719857
Compare
The scripted source-dependencies/value-class is failing for an unknown reason. I can reproduce the bug with sbt-dotty but I cannot reproduce it without sbt-dotty. So I think it is not worth trying to fix it.
adpi2
force-pushed
the
fix-scalaBinaryVersion
branch
2 times, most recently
from
9f2e2fd to
9c457b4
Compare
|
@smarter could you review this? |
|
Instead of updating DEFAULT_MILL_VERSION in each submodule, could we set MILL_VERSION in the community build runner itself? (this seems like a good idea in general, in the same way that we use a single sbt version for the whole community build). I haven't checked but a change like this should work: diff --git community-build/src/scala/dotty/communitybuild/projects.scala community-build/src/scala/dotty/communitybuild/projects.scala
index 755f774449f..c32a3ed6839 100644
--- community-build/src/scala/dotty/communitybuild/projects.scala
+++ community-build/src/scala/dotty/communitybuild/projects.scala
@@ -25,6 +25,7 @@ def exec(projectDir: Path, binary: String, arguments: String*): Int =
val command = binary +: arguments
log(command.mkString(" "))
val builder = new ProcessBuilder(command: _*).directory(projectDir.toFile).inheritIO()
+ builder.environment.put("MILL_VERSION", "0.9.6-16-a5da34")
val process = builder.start()
val exitCode = process.waitFor()
exitCode |
adpi2
force-pushed
the
fix-scalaBinaryVersion
branch
from
9c457b4 to
5a7f79f
Compare
adpi2
force-pushed
the
fix-scalaBinaryVersion
branch
from
5a7f79f to
c0d4e35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.