WIP - Fix 11924 #11925
Closed
WIP - Fix 11924 #11925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I ran the tests locally many things broke, so I don't think this is a viable approach as is. See also the discussion in #11924. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick trial to see if #11924 can be fixed simply by always creating a type-annotated binding for inlined method arguments.
I did not try to make the change for transparent inline methods (thus the
ctx.phase == Phases.typerPhase), as that would likely raise many problems, since these inline methods do influence type checking. I suspect more extensive changes would be needed to support these.