Type ascribe arguments of bottom type to inline functions #11917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Mar 27, 2021
| true | ||
| computeParamBindings( | ||
| tp.resultType, targs.drop(tp.paramNames.length), argss, | ||
| paramSubst.andThen(_.substParams(tp, targs.map(_.tpe.stripTypeVar)))) |
There was a problem hiding this comment.
It seems the usage of tp will disregard the prefix -- maybe methPart.tpe.widen is more accurate? Meanwhile, the current fix does not handle dependent types. Will it be simpler to extract the types from the fun part of Apply trees instead of recomputing them?
There was a problem hiding this comment.
Good observation. Yes, that should be fixed.
liufengyun
approved these changes
Mar 28, 2021
| def paramTypess(call: Tree, acc: List[List[Type]]): List[List[Type]] = call match | ||
| case Apply(fn, args) => | ||
| fn.tpe.widen.match | ||
| case mt: MethodType => paramTypess(fn, mt.instantiateParamInfos(args.tpes) :: acc) |
There was a problem hiding this comment.
I'm wondering will mt.paramInfos work here?
There was a problem hiding this comment.
No, because parameter types can depend on parameters in the same clause.
There was a problem hiding this comment.
That's tested in test4, which failed before when I used paramInfos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11864
Fixes #8612