Skip to content

Community build: Adapt utest for #11769 #11887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2021

Conversation

griggt
Copy link
Contributor

@griggt griggt commented Mar 25, 2021

Ref: #11769 (comment)

The first commit allows the tests to pass, however it just reflects that the message contained in the utest.AssertionError now contains syntactically invalid source code, which seems undesirable.

The second commit contains a proposed fix.

@griggt griggt marked this pull request as draft March 25, 2021 01:51
@griggt griggt changed the title Community build: Adapt utest tests for #11769 Community build: Adapt utest for #11769 Mar 25, 2021
@griggt griggt marked this pull request as ready for review March 25, 2021 03:11
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! I was not sure what to do there since I don't know utest.

@odersky odersky merged commit 2cf1152 into scala:master Mar 25, 2021
@griggt griggt deleted the adapt-utest-tests-for-#11769 branch March 25, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants