Fix #11872, correct error msg when modifier flag is not allowed #11878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornregnell
changed the title
bjornregnell
changed the title
|
I can not claim that I understand the checking in general, so good if someone can verify the the wider type in param of |
odersky
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Looks good to me.
@bjornregnell Can you rebase this to latest master force push? You had the bad luck to push your PR in top of a cursed master that failed all derived PRs. But that's fixed now.
|
@odersky Thanks. Rebased and force-pushed just now. |
|
Thanks for the fast reaction! That way it can still go in 3.0 RC2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModifierNotAllowedForDefinitionnow takes aFlagSetinstead of just aFlag, which makes sense as it should report error for the flags used even if more than one andFlag <: FlagSet. And then the hard-codedErasedis replaced by the actualflag: FlagSet.