Fix member lookups for inherited members #11821
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarkingBad
force-pushed
the
scaladoc/fix-member-lookups
branch
from
e98d9ef to
76aec60
Compare
abgruszecki
reviewed
Mar 21, 2021
| }.orElse { | ||
| val symbol = owner.memberField(qs.head) | ||
| Option.when(symbol != dotty.tools.dotc.core.Symbols.NoSymbol)(symbol).map((_, Some(owner))) | ||
| } |
There was a problem hiding this comment.
Ah, it seems that the code we had previously didn't actually look up inherited members at all? In that case it'll have to be changed. We don't want to simply go through Scala Reflect functions here, we also need to take into account absent symbols (see hackIsNotAbsent).
This code also doesn't seem to work when the inherited symbol is in the middle of the query. In general it'd be better to modify localLookup instead of downwardLookup.
| pk.flatMap(downwardLookup(qs, _)) | ||
| .orElse(tp.flatMap(downwardLookup(qs, _))) | ||
| .orElse(tp.flatMap(downwardLookUpForInheritedMembers(qs, _))) | ||
| .orElse(tm.flatMap(downwardLookup(qs, _))) |
There was a problem hiding this comment.
Inherited symbols can also appear in term symbols (objects, that is).
|
Closing in favour of #11850. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://scala3doc.virtuslab.com/pr-fix-member-lookups/testcases/api/tests/lookupInheritedMembers/LookupInheritedMembers.html