Upgrade to Scalajs 1.5.0 and implement custom JS function types #11818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes forward ports of the compiler changes in the following upstream commits: - scala-js/scala-js@5a15add Encode fields of type Nothing with scala.runtime.Nothing$. - scala-js/scala-js@294efab Do not emit abstract methods in non-native JS classes. - scala-js/scala-js@f0476c0 Encode allowed LHS of Assign in type system - scala-js/scala-js@df5b3c6 Replace `rest` field in `ir.ParamDef` with special members It does *not* contain the changes from the upstream commit - scala-js/scala-js@7edacf5 Generalize js.Function's to allow user-defined ones. Porting the support for custom JS function types is left for a separate commit for this repo. This means that we need to blacklist the new upstream test file `CustomJSFunctionTest.scala`.
Forward port of the upstream commit scala-js/scala-js@b6ef9a6
Forward port of the upstream commit scala-js/scala-js@7edacf5
|
@anatoliykmetyuk There are two failures in the Scala.js tests, related to JavaScript Symbols. I cannot reproduce those errors locally. Perhaps the Node.js version used by the CI is too old? I have v14.15.0 on my computer. |
We need Node 14 to get some Scala.js 1.5.0 tests to pass, but since I had to regenerate the docker image I also upgraded the JDK to the latest release.
|
Thanks @smarter. It's green now :) |
nicolasstucki
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.