Skip EnumValue as supertype of enum values in semanticdb #11807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Mar 23, 2021
| @@ -154,7 +154,7 @@ class ExtractSemanticDB extends Phase: | |||
| if tree.symbol.isAllOf(EnumValue) => | |||
| tree.rhs match | |||
| case Block(TypeDef(_, template: Template) :: _, _) => // simple case with specialised extends clause | |||
| template.parents.foreach(traverse) | |||
| template.parents.filter(_.symbol != defn.EnumValueClass).foreach(traverse) | |||
There was a problem hiding this comment.
this does not work if someone explicitly writes runtime.EnumValue as a parent
enum Color/*<-enumVal::Color#*/(val rgb/*<-enumVal::Color#rgb.*/: Int/*->scala::Int#*/):
case Red/*<-enumVal::Color.Red.*/ extends Color/*->enumVal::Color#*/(0xFF0000) with runtime.EnumValue
/*<-enumVal::EnumVal$package.*/val e/*<-enumVal::EnumVal$package.e.*/: scala.runtime.EnumValue/*->scala::runtime::EnumValue#*/ = ???/*->scala::Predef.`???`().*/
bishabosha
requested changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11689
The information that enum values are internally extending
scala.runtime.EnumValueshouldn't be present in semanticdb as this is not visible from the outside of the enum, that is, enum values cannot be assigned to value with typescala.runtime.EnumValue.