fix command line processing error #1176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,7 +40,7 @@ class ScalaSettings extends Settings.SettingGroup { | |||
| val jvmargs = PrefixSetting("-J<flag>", "-J", "Pass <flag> directly to the runtime system.") | |||
| val defines = PrefixSetting("-Dproperty=value", "-D", "Pass -Dproperty=value directly to the runtime system.") | |||
| val toolcp = PathSetting("-toolcp", "Add to the runner classpath.", "") | |||
| val nobootcp = BooleanSetting("-nobootcp", "Do not use the boot classpath for the scala jars.") | |||
There was a problem hiding this comment.
I do not think we should rename options inherited from scalac, unless they have different meaning.
There was a problem hiding this comment.
OK, then I change ./bin/dotc to accept -nobootcp instead of -no-bootcp.
|
I've updated the commit with only changes to |
|
@DarkDimius Can we merge this? |
|
LGTM |
DarkDimius
added a commit
that referenced
this pull request
Mar 18, 2016
fix command line processing error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix command line error for
-helpand-no-bootcp.