Do not allow calls to inline methods directly in macro splice #11746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also properly support canceled macro splices. These will warn the user and compile as if they where a normal inline method. Fixes scala#11688
nicolasstucki
changed the title
|
Then I guess you should also fix the error message which I quoted in #11688. Emphasis mine:
|
liufengyun
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
The same issue as pointed out by @Jasper-M . Otherwise, LGTM
It was written for an older version of the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also properly support canceled macro splices. These will warn the user and compile as if
they where a normal inline method.
Fixes #11688