Skip to content

Add PSBP (old name: PDBP) to community build #11722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2021

Conversation

abgruszecki
Copy link
Contributor

@psbp-library thanks for reaching out to (re)include your project in the community build, here's the PR.

@abgruszecki
Copy link
Contributor Author

@OlivierBlanvillain for some reason, cloning the new repo fails with:

Cloning into '/__w/dotty/dotty/community-build/community-projects/psbp'...
Host key verification failed.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of '[email protected]:PSBP-Library/psbp-library.github.io.git' into submodule path '/__w/dotty/dotty/community-build/community-projects/psbp' failed
Failed to clone 'community-build/community-projects/psbp' a second time, aborting

This is despite the repo being public. I can clone it locally no problem. Do you have an idea what could be going on?

.gitmodules Outdated
@@ -193,3 +190,6 @@
[submodule "community-build/community-projects/cask"]
path = community-build/community-projects/cask
url = https://github.com/dotty-staging/cask.git
[submodule "community-build/community-projects/psbp"]
path = community-build/community-projects/psbp
url = https://github.com/PSBP-Library/psbp-library.github.io.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep pointing to our fork, but I didn't follow the latest community build changes...
wdyt @anatoliykmetyuk?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that’s right. I created a fork: https://github.com/dotty-staging/psbp-library.github.io
And invited @PSBP-Library there. Please point to this repo.

@OlivierBlanvillain
Copy link
Contributor

This is despite the repo being public. I can clone it locally no problem. Do you have an idea what could be going on?

That's weird, could it related to using https instead of git for the submodule?

@abgruszecki
Copy link
Contributor Author

This is despite the repo being public. I can clone it locally no problem. Do you have an idea what could be going on?

That's weird, could it related to using https instead of git for the submodule?

Yep, that was the case. @griggt showed me how to fix it (thanks!).

@abgruszecki abgruszecki force-pushed the psbp4community-build branch from feddcab to df06c34 Compare March 23, 2021 11:01
@abgruszecki abgruszecki enabled auto-merge March 23, 2021 11:02
@abgruszecki abgruszecki merged commit 641c928 into scala:master Mar 23, 2021
@abgruszecki abgruszecki deleted the psbp4community-build branch March 23, 2021 13:08
abgruszecki added a commit to dotty-staging/dotty that referenced this pull request Mar 24, 2021
…ity-build"

This reverts commit 641c928, reversing
changes made to 00cf0b7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants