-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add PSBP (old name: PDBP) to community build #11722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@OlivierBlanvillain for some reason, cloning the new repo fails with:
This is despite the repo being public. I can clone it locally no problem. Do you have an idea what could be going on? |
.gitmodules
Outdated
@@ -193,3 +190,6 @@ | |||
[submodule "community-build/community-projects/cask"] | |||
path = community-build/community-projects/cask | |||
url = https://github.com/dotty-staging/cask.git | |||
[submodule "community-build/community-projects/psbp"] | |||
path = community-build/community-projects/psbp | |||
url = https://github.com/PSBP-Library/psbp-library.github.io.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep pointing to our fork, but I didn't follow the latest community build changes...
wdyt @anatoliykmetyuk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that’s right. I created a fork: https://github.com/dotty-staging/psbp-library.github.io
And invited @PSBP-Library there. Please point to this repo.
That's weird, could it related to using https instead of git for the submodule? |
Yep, that was the case. @griggt showed me how to fix it (thanks!). |
Co-authored-by: Tom Grigg <[email protected]>
feddcab
to
df06c34
Compare
@psbp-library thanks for reaching out to (re)include your project in the community build, here's the PR.