reduced number of Logarithm #11677
Merged
reduced number of Logarithm #11677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the change, but I think you forgot to update the text which still references the old |
|
@OlivierBlanvillain - indeed thanks for the comment! should be fixed now! |
OlivierBlanvillain
approved these changes
Mar 13, 2021
|
Thanks! |
shinharad
added a commit
to shinharad/getting-started-with-scala3
that referenced
this pull request
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the example 3 logarithm(s) are used (object 2x and type). It makes reading hard. To make it simpler, I'd suggest:
Object Logarithmsat allObject LogarithmswithMyMath(this pull request)