Skip to content

Add protoquill to community-build #11611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2021
Merged

Add protoquill to community-build #11611

merged 1 commit into from
Mar 5, 2021

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Mar 5, 2021 •
edited
Loading

Based on protoquill building on latest nightly: https://github.com/getquill/protoquill/tree/RC2_Nighly

Ping @deusaquilus

@nicolasstucki nicolasstucki self-assigned this Mar 5, 2021
@nicolasstucki nicolasstucki force-pushed the add-protoquill-to-community-build branch from ea488d6 to c4bb311 Compare March 5, 2021 10:23
nicolasstucki
nicolasstucki commented Mar 5, 2021
View reviewed changes
@deusaquilus
Copy link
Contributor

@nicolasstucki @liufengyun Great to see this happening! Thank you!

@nicolasstucki nicolasstucki force-pushed the add-protoquill-to-community-build branch from c4bb311 to 379de8a Compare March 5, 2021 15:49
@nicolasstucki
Copy link
Contributor Author

@deusaquilus it would be good if you can enable the scalaOption += "-Ycheck:all". I noticed that something breaks with it enabled. If you manage to minimize it would help us stabilizing the compiler for the compilation of quill.

@deusaquilus
Copy link
Contributor

deusaquilus commented Mar 5, 2021 •
edited
Loading

It looks like the "-Ycheck:all" problem is in MirrorContext.scala. I expect it will probably blow in many more things in my testing codebase. (Edit: Nope, actually testing codebase seems fine)

@nicolasstucki nicolasstucki marked this pull request as ready for review March 5, 2021 21:35
@nicolasstucki nicolasstucki requested a review from liufengyun March 5, 2021 21:36
liufengyun
liufengyun approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 0e9b84c into scala:master Mar 5, 2021
@nicolasstucki nicolasstucki deleted the add-protoquill-to-community-build branch March 5, 2021 21:52
@deusaquilus
Copy link
Contributor

It looks like the problem is in @targetName("runQuery"). Build with "-Ycheck:all" works when I remove it.

@deusaquilus
Copy link
Contributor

@nicolasstucki Is the testing code also being compiled? That's where most of the breakages happen.

@deusaquilus deusaquilus mentioned this pull request Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @deusaquilus @liufengyun