Add missing flags from case bindings in TASTy #11595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#11594
branch
from
39d07ec to
6b19365
Compare
nicolasstucki
commented
Mar 4, 2021
| pickleName(name) | ||
| pickleType(sym.info) | ||
| pickleTree(body) | ||
| pickleFlags(sym.flags &~ Case, sym.isTerm) |
There was a problem hiding this comment.
Do we need to allow other modifiers like annotations? Can these be on the binding or are they always on the type?
There was a problem hiding this comment.
They should be on the type. Are there other flags on bound symbols except Implicit or Given?
There was a problem hiding this comment.
Not now. But I could imagine there could be a Synthetic flag added to some of those.
It may also make sense to have Erased and Inline in the future. Such as in #11598.
odersky
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11594