Skip to content

Move Staging phase after Inlining #11593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

This phase needs to check any code that might be generated by macros through the reflection API.

@nicolasstucki nicolasstucki force-pushed the move-staging-phase-after-inlining branch 3 times, most recently from d27aecc to 3d2c6ec Compare March 3, 2021 20:16
@nicolasstucki nicolasstucki self-assigned this Mar 3, 2021
@nicolasstucki nicolasstucki force-pushed the move-staging-phase-after-inlining branch from 3d2c6ec to 8a04895 Compare March 4, 2021 09:59
@nicolasstucki nicolasstucki added this to the 3.0.0-RC2 milestone Mar 4, 2021
This phase needs to check any code that might be generated by macros through the reflection API.
@nicolasstucki nicolasstucki force-pushed the move-staging-phase-after-inlining branch from 8a04895 to cea49cf Compare March 4, 2021 19:27
@nicolasstucki nicolasstucki marked this pull request as ready for review March 4, 2021 21:57
@nicolasstucki nicolasstucki requested a review from liufengyun March 4, 2021 21:57
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit e3a3974 into scala:master Mar 5, 2021
@nicolasstucki nicolasstucki deleted the move-staging-phase-after-inlining branch March 5, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants