Heal type within quote internal encoding #11590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Mar 3, 2021
| val targs1 = targs.map(targ => TypeTree(heal(targ.tpe))) | ||
| cpy.Apply(quote)(cpy.TypeApply(fn1)(fn0, targs1), body2 :: Nil) | ||
| case quote: TypeApply => | ||
| cpy.TypeApply(quote)(quote.fun, body2 :: Nil) |
There was a problem hiding this comment.
At line 119, body2 could be a block, and it's used as a type. I guess this case not reachable if body2 is a block.
There was a problem hiding this comment.
Indeed, is not reachable. This is essentially the same logic as in super.transformQuotation.
| case AnnotatedType(parent, annot) => AnnotatedType(mapOver(parent), annot) | ||
| case _ => healTypeOfTerm(fn1.srcPos)(tp) | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm wondering why this is not already handled in the recursive call? Can it be handled in transform? I'm wondering if it's possible to avoid the heal TypeMap here and move the logic to healTypeOfTerm -- as there's also a TypeMap there.
There was a problem hiding this comment.
Moved into healTypeOfTerm
nicolasstucki
force-pushed
the
fix-#11587-2
branch
from
1159170 to
8447d5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11587