Change GADT constrainer to consider all parents of the scrutinee type when upcasting it #11521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abgruszecki
reviewed
Mar 12, 2021
| scrut.firstParent | ||
| // consider all parents | ||
| val parents = scrut.parents | ||
| val andType = trace(i"andType of scrut", gadts) { |
There was a problem hiding this comment.
This trace doesn't seem overall very useful, could you remove it?
| val andType = trace(i"andType of scrut", gadts) { | ||
| buildAndType(parents) | ||
| } | ||
| constrainPatternType(pat, andType) |
There was a problem hiding this comment.
Can you check if andType exists, like in case _ below?
| case _ => NoType | ||
| val allSyms = allParentsSharedWithPat(tycon, tycon.symbol.asClass) | ||
| val baseClasses = allSyms map scrut.baseType | ||
| val andType = trace(i"andType of scrut", gadts) { |
There was a problem hiding this comment.
Ditto about the trace.
| val andType = trace(i"andType of scrut", gadts) { | ||
| buildAndType(baseClasses) | ||
| } | ||
| constrainPatternType(pat, andType) |
There was a problem hiding this comment.
Ditto about andType existing.
|
Thank you for your review! I have removed unnecessary traces and added the existence checking. It's really good that we can include this feature in 3.0.0. :) |
abgruszecki
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.