Add automated test to check if scaladoc sourcelinks are correctly pointing to remote repository #11512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarkingBad
force-pushed
the
scala3doc/source-links-tests
branch
from
cb2ccef to
5abd9d9
Compare
BarkingBad
force-pushed
the
scala3doc/source-links-tests
branch
3 times, most recently
from
2ba4ef4 to
50d1a59
Compare
BarkingBad
force-pushed
the
scala3doc/source-links-tests
branch
3 times, most recently
from
8a6899c to
ef44e1d
Compare
|
PR is blocked by #11547 |
BarkingBad
force-pushed
the
scala3doc/source-links-tests
branch
2 times, most recently
from
ed69939 to
deaebe0
Compare
pikinier20
suggested changes
May 6, 2021
scaladoc/test-source-links/dotty/tools/scaladoc/source-links/RemoteLinksTest.scala
Outdated
Show resolved
Hide resolved
BarkingBad
force-pushed
the
scala3doc/source-links-tests
branch
from
4d05dfc to
e1449b6
Compare
BarkingBad
force-pushed
the
scala3doc/source-links-tests
branch
4 times, most recently
from
3fa3732 to
ad76ed7
Compare
romanowski
reviewed
May 11, 2021
|
|
||
| class TimeoutException extends Exception | ||
|
|
||
| Random.setSeed(125L) |
There was a problem hiding this comment.
IMHO we should use a local instance of Random rather then setting seed globally
BarkingBad
force-pushed
the
scala3doc/source-links-tests
branch
from
ad76ed7 to
37ed4b7
Compare
romanowski
approved these changes
May 11, 2021
pikinier20
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.