Skip to content

Fix docs #11427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 16, 2021
Merged

Fix docs #11427

merged 7 commits into from
Feb 16, 2021

Conversation

ShapelessCat
Copy link
Contributor

@ShapelessCat ShapelessCat commented Feb 16, 2021 •
edited
Loading

  • Fix the syntax of a sentence
  • Fix some code examples
  • Use _ to simplify some pattern matching code examples
  • Fix a comment in a code example
  • Change some code examples to follow the Scala coding style conventions
  • Capitalize the initial letters of words in a title
  • Change the way of writing a extension method header, which is more suitable in its context

@ShapelessCat
Fix docs
4034fe0 
- Fix the syntax of a sentence
- Fix a code example
@ShapelessCat ShapelessCat marked this pull request as draft February 16, 2021 03:10
@ShapelessCat ShapelessCat marked this pull request as ready for review February 16, 2021 06:57
@ShapelessCat
Capitalize the initial letters of words in a title
2f48b6e
@ShapelessCat
Change the way of writing a extension method header
a1fdf1e 
- This subsection explains generic extensions WITHOUT using clause(s) first,
  and then explains generic extensions WITH using clause(s).
    The changed code is for the first part, and don't introduce using clause(s)
  in it is more suitable in this context.
@ShapelessCat ShapelessCat marked this pull request as draft February 16, 2021 08:21
@ShapelessCat ShapelessCat marked this pull request as ready for review February 16, 2021 08:22
liufengyun
liufengyun approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ShapelessCat 🎉

@liufengyun liufengyun merged commit ffa59c8 into scala:master Feb 16, 2021
@ShapelessCat ShapelessCat deleted the fix-minor-issues-in-docs branch February 16, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShapelessCat @liufengyun