Skip to content

UX scaladoc improvements #11396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Conversation

BarkingBad
Copy link
Contributor

No description provided.

@BarkingBad BarkingBad linked an issue Feb 12, 2021 that may be closed by this pull request
Copy link
Contributor

@romanowski romanowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss if we should revert the sorting thing online, for now we can merge the PR.


private def actualGroup(name: String, members: Seq[Member | MGroup]): Seq[AppliedTag] =
if members.isEmpty then Nil else
div(cls := "documentableList")(
h3(cls:="groupHeader")(name),
members.map {
members.sortBy {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Members are sort by poistion in the source files/files. Three is a way to sort members by name using buttons.

@romanowski romanowski enabled auto-merge February 12, 2021 15:30
@BarkingBad
Copy link
Contributor Author

Let's discuss if we should revert the sorting thing online, for now we can merge the PR.

Actually was answering the @Katrix request, but I must have missed the custom sorts. Talking it over is a good idea.

@romanowski romanowski merged commit 33fca15 into scala:master Feb 12, 2021
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala3doc UI and UX improvements
3 participants