-
Notifications
You must be signed in to change notification settings - Fork 1.1k
new TASTy header format - add experimental version and tooling version fields #11343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4eaddd5
to
7601941
Compare
This should be reformulated to again swap |
b152c19
to
3390bad
Compare
For reviewers, I need to know advice on what should be the contents of the "toolingVersion" field in the header, for example, should we record somewhere the "minimum" compiler version that is compatible with the current TASTy version (and expose it in Also, since #11167 we have been providing the option to return the fields in the header to the user, and we are generating new String objects to store the compiler version, should there be some caching? (note that we do not have access to the |
Here we adds fields for experimental and tooling versions. - ExperimentalVersion: Nat, when reading non-zero and we are non-zero, the file must be at same version. Otherwise if we are non-zero, the file must have zero experimental version, and must be of strictly lower minor version. - ToolingVersion: String, an arbitrary UTF-8 string that says the name+version of the tooling that produced the file. We could reinterpret to mean the "minimum" version required to read that file, but that would require more process to record that.
3390bad
to
ad7c20c
Compare
0aef65b
to
496127d
Compare
Here we adds fields for experimental and tooling versions.
we are non-zero, the file must be at same version.
Otherwise if we are non-zero, the file must have
zero experimental version, and must be of strictly
lower minor version.
that says the name+version of the tooling that
produced the file. We could reinterpret to mean
the "minimum" version required to read that file,
but that would require more process to record that.
fixes #10375