rename scala3doc into scaladoc #11289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abgruszecki
reviewed
Feb 2, 2021
| @@ -23,7 +23,7 @@ object DottyPlugin extends AutoPlugin { | |||
| val isDotty = settingKey[Boolean]("Is this project compiled with Dotty?") | |||
| val isDottyJS = settingKey[Boolean]("Is this project compiled with Dotty and Scala.js?") | |||
|
|
|||
| val useScala3doc = settingKey[Boolean]("Use Scala3doc as the documentation tool") | |||
| val useScaladoc = settingKey[Boolean]("Use scaladoc as the documentation tool") | |||
There was a problem hiding this comment.
Does the new name really make sense here? Perhaps we should call this key useNewScaladoc?
There was a problem hiding this comment.
Next step would be removing scala3-doc and this setting as well.
romanowski
force-pushed
the
scala3doc/cleanup
branch
from
35bada9 to
706c710
Compare
BarkingBad
approved these changes
Feb 2, 2021
abgruszecki
reviewed
Feb 3, 2021
romanowski
force-pushed
the
scala3doc/cleanup
branch
from
c5f1833 to
21c27bf
Compare
romanowski
force-pushed
the
scala3doc/cleanup
branch
from
21c27bf to
ccb76da
Compare
eed3si9n
added a commit
to eed3si9n/librarymanagement
that referenced
this pull request
Feb 14, 2021
eed3si9n
added a commit
to eed3si9n/sbt
that referenced
this pull request
Feb 14, 2021
Fixes sbt#6307 Ref sbt/librarymanagement#365 Ref scala/scala3#11289 This adds test using M4 nightly, which now uses artifact name `scaladoc_3.0.0-M4` as oposed to `scala3doc_3.0.0-M3`. The change in LM keeps the support for the old artifact name for backward compatibility to build against 3.0.0-M1, -M2, and -M3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename scaladoc package to
dotty.tools.scaladocThis PR makes a lot of mechanical renames.